A few questions from the developer:
The cookie handling code is almost directly taken from Drupal's own source code. I also re-tested it on my own Drupal site and it works correctly. The last few things I can think of, beside the obvious (incorrect database prefix and such):
- Is he referring to the correct settings.php file? If he has multiple copies of it (for example if he has multiple sites), his site might be using a different settings.php located elsewhere.
- Is he using https? Drupal uses different cookies whether you're logged using http or https. You need to access LOTRoster using the same protocol to ensure you access the right cookie.
- Have him make sure $base_url is properly set in Drupal's settings.php. It should be
"http://site.com/core", with no trailing slash. LOTRoster relies on that parameter to build the correct cookie name.
- Does he have anything set in $cookiedomain in settings.php? I have only tested with this parameter being left commented out (so $cookiedomain is built dynamically by Drupal and LOTRoster)
Beside that, he'll have to check himself what's the name of the cookie his Drupal site sets when he's logged in (Firefox's cookie manager can easily let him do that, no idea about Internet Explorer or other browsers), and ensure it matches $cookiename auth/drupal.php is trying to look up on line 62. He can insert a:
echo $cookiename;
just before that line if he wishes to compare it with what cookie his browser has set.