Thread: [Plugin] LotroLCD

Originally Posted by Vindalfur

I have a feature request from another user for just this, showing average dps per session with an optional reset button, It's going to be included in the next release which should be ready soon.

Just released version 1.0.6 which has a new data element called hdps (history dps), this element shows the average dps since LotroLCD (the exe) was started. Due to time constraints I left the reset/clear and settings buttons for the next release but the UI is a lot better and LUA performance has been improved by a factor of 1000 or so.

You can use the same links as before to download the new version.

You might want to add to the OP and the readme text file that this plugin requires the Turbine Lua files. They're reference in your main LUA file:

Code:

import "Turbine";
import "Turbine.Gameplay";
import "Turbine.UI";
import "Turbine.UI.Lotro";
import "Turbine.Utils";

Or, to be sure that your LOTRO LCD plugin works whenever Turbine releases an update to their API and libraries, include these within your installer automatically. Therefore, check to see if they exist. If they do, prompt the user if they wish to overwrite their copy with yours. If they don't exist it, gracefully copy them over so that your plugin works regardless of what an end-user has.

I have the APIs and everything on my work PC, but not on my home PC where I play LOTRO, so when your plugin failed to load (/plugins load lotrolcd), I checked and sure enough your plugin requires the optional Turbine files.

Thanks.

And it looks like it break on my PC ...

I installed the 64-bit app since I'm on Windows 7 Ultimate 64-bit RTM. I ran it from the desktop shortcut. I saw it up and running, recognized by my G19 software and listed on my G19's LCD. I then did the /plugins load lotrolcd, and it ran just fine. I create a Combat tab since I don't normally use one, with Combat and Combat Event filters. Then I logged my IM tab (as apparently needed by the app). At this point I get six bars across my G19's LCD that are about a few pixels wide (I assume that's normal w/ no logged info yet?).

So the next time I do damage to a mob, my screen flashes (since I run LOTRO in full screen) and on the desktop, in the background I get...



I even did /lotrolcd show to check (before the error appeared) and nothing happened.

Thoughts?

Thanks for pointing that out, I've added an issue to my bug list, I'll have it fixed for the next release.
See:
http://code.google.com/p/lotrolcd/issues/detail?id=23
R.

Jarl

Originally Posted by cipher_nemo

You might want to add to the OP and the readme text file that this plugin requires the Turbine Lua files. They're reference in your main LUA file:

Code:

import "Turbine";
import "Turbine.Gameplay";
import "Turbine.UI";
import "Turbine.UI.Lotro";
import "Turbine.Utils";

Or, to be sure that your LOTRO LCD plugin works whenever Turbine releases an update to their API and libraries, include these within your installer automatically. Therefore, check to see if they exist. If they do, prompt the user if they wish to overwrite their copy with yours. If they don't exist it, gracefully copy them over so that your plugin works regardless of what an end-user has.

I have the APIs and everything on my work PC, but not on my home PC where I play LOTRO, so when your plugin failed to load (/plugins load lotrolcd), I checked and sure enough your plugin requires the optional Turbine files.

Thanks.

Hi,

You should no longer need to start any logging for those 6 bars to show, they should show immediately after you start LotroLCD.exe and be visible from there on.

The error in question means that LotroLCD failed to read any data from one of the log files.

Can you confirm that you are running version 1.0.6 (version 1.0.6 should show version number inside LUA UI), also could you verify that your log files are located under C:\Users\username\Documents\Th e Lord of the Rings Online\ ?

If you are running version 1.0.6 you might be affected by a recently fixed bug that crept in, I've fixed that particular bug but I have not released a new version since but I'll do a bugfix release if this is affecting you.

If it is the bug I have in mind the workaround is to move all existing IM and Combat logs into another directory (or delete them) and restart the client.

Originally Posted by cipher_nemo

And it looks like it break on my PC ...

I installed the 64-bit app since I'm on Windows 7 Ultimate 64-bit RTM. I ran it from the desktop shortcut. I saw it up and running, recognized by my G19 software and listed on my G19's LCD. I then did the /plugins load lotrolcd, and it ran just fine. I create a Combat tab since I don't normally use one, with Combat and Combat Event filters. Then I logged my IM tab (as apparently needed by the app). At this point I get six bars across my G19's LCD that are about a few pixels wide (I assume that's normal w/ no logged info yet?).

So the next time I do damage to a mob, my screen flashes (since I run LOTRO in full screen) and on the desktop, in the background I get...



I even did /lotrolcd show to check (before the error appeared) and nothing happened.

Thoughts?

Originally Posted by Vindalfur

You should no longer need to start any logging for those 6 bars to show, they should show immediately after you start LotroLCD.exe and be visible from there on.

Good to know, thanks. Might want to update your readme file included with the program to reflect this.

Originally Posted by Vindalfur

Can you confirm that you are running version 1.0.6 (version 1.0.6 should show version number inside LUA UI)

Code:

<?xml version="1.0"?>
<Plugin>
    <Information>
        <Name>LotroLCD</Name>
        <Author>Vindalfur</Author>
        <Version>0.3</Version>
    </Information>
    <Package>LotroLCD.LotroLCD.Main</Package>
</Plugin>

I downloaded the 64-bit version from your OP over the last weekend (either Friday, Saturday, or Sunday). But yout LotroLCD.plugin file states version "0.3" unless you haven't updated this file? So that would be the version shown to LOTRO as well. Also, there is no version information within the executable you released (that gets installed and given a shortcut on the desktop). There's no version information within the Logitech LCD manager either for your app.

Originally Posted by Vindalfur

also could you verify that your log files are located under C:\Users\username\Documents\Th e Lord of the Rings Online\ ?

It's "My Documents", but yes, there is one for Combat and IM since I manually started the logging on each...

Combat_20101101_1.txt
IMs_Generic IMs_20101101_1.txt

Originally Posted by Vindalfur

If it is the bug I have in mind the workaround is to move all existing IM and Combat logs into another directory (or delete them) and restart the client.

I'll try that tomorrow, thanks.

Originally Posted by cipher_nemo

Good to know, thanks. Might want to update your readme file included with the program to reflect this.

It's "My Documents", but yes, there is one for Combat and IM since I manually started the logging on each...

Combat_20101101_1.txt
IMs_Generic IMs_20101101_1.txt


I'll try that tomorrow, thanks.

Sorry, I wasn't clear enough, I've updated the readme and it will be in the next version.

1. Does your Plugin UI look like this and does it have 1.0.6 verision at the bottom?



By the way, thanks for pointing out the version in the plugin files, I forgot those were versioned, now I sync the version shown in the client to those and update them to match the Installer/Exe version (which is not shown currently but that's on my tasklist).

2. If you actually want to get the IM log file functionality for your keyboard (it can show things like spell timers, messages, etc) you want to log only messages to yourself, not the Generic IM log, otherwise don't log messages at all, I'm betting the Generic log is causing the issues you have so I suggest deleting it.

Originally Posted by Vindalfur

1. Does your Plugin UI look like this and does it have 1.0.6 verision at the bottom?

Nope. It was a blank window. And the border was not simple as in your image. It had a fancy border around it, but when I clicked on the title it minimized to the simple border with just the title.

Originally Posted by Vindalfur

2. If you actually want to get the IM log file functionality for your keyboard (it can show things like spell timers, messages, etc) you want to log only messages to yourself, not the Generic IM log, otherwise don't log messages at all, I'm betting the Generic log is causing the issues you have so I suggest deleting it.

Sounds good, I'll give it a try. I assume, though, that I'm better off deleting the log files and letting the plugin create its own as you mentioned earlier?

Originally Posted by cipher_nemo

Nope. It was a blank window. And the border was not simple as in your image. It had a fancy border around it, but when I clicked on the title it minimized to the simple border with just the title.

Sounds good, I'll give it a try. I assume, though, that I'm better off deleting the log files and letting the plugin create its own as you mentioned earlier?

Ok, you just have the default UI skin, while I have a custom skin, I just wanted to know that you had version 1.0.6 (which you do have based on your desc). The old UI was just a black screen with no way to minimize.
I suggest you start by deleting or moving the log files, getting the combat log things to work then you can start working on the timer things.

Sounds like a neat plugin. I use Windows7 64bit and have the same issue with the error so I'm excited about maybe 1.07

I'd like to make a suggestion. Even though I will likely use the LCD portion of the plugin with a G19, it is a process that runs even if I disable the plugin in game. And the error is a windows error, so it yanks me out of the game tab. Maybe offer up a plugin only version and a plugin+LCD version so people aren't installing running processes that they don't need if they don't want?

Thanks for the work.

Hi,

The error you are referring to is fixed for the next version, actually those errors are not supposed to be shown unless you are developing the application but unfortunately the last version shows it to everyone.

About the plugin and the process, the process is required for the plugin to work, the process is actually doing all the real work while the plugin is just showing the data, the data is not available inside standard Lotro so the process is responsible for getting all the data from log files and making it available to the plugin so I'm afraid the process is always required, the plugin is optional however.

I'll try making a new release tonight to fix outstanding issues, I just have to do some testing first.

Originally Posted by hucklebarry

Sounds like a neat plugin. I use Windows7 64bit and have the same issue with the error so I'm excited about maybe 1.07

I'd like to make a suggestion. Even though I will likely use the LCD portion of the plugin with a G19, it is a process that runs even if I disable the plugin in game. And the error is a windows error, so it yanks me out of the game tab. Maybe offer up a plugin only version and a plugin+LCD version so people aren't installing running processes that they don't need if they don't want?

Thanks for the work.

Just released version 1.0.8

Mostly version 1.0.8 just fixes bugs and issues found in previous releases, including popup error messages, missing Turbine plugin files when first plugin installed, issues with combat status in LUA plugin, performance and more.

As usual the new version can be downloaded from the same links as before (see first post in thread).

If you do have any issues or requests please post them, It's hard to imagine every possible situation and without feedback I won't be able to improve the plugin.

Hello,

I have just tried to run your plugin. It seems to load well:

I start the .exe file
Start lotro
Load char
Load lcd plugin
Start combat logging
<now I can see the ingame pluging window>
When I attack something, it alt+tabs to windows and I get this error:

PointToStart failed with error code6 as follows:
The handle is invalid.

EDIT: And now I see where I did mistake, should start combat logging before loading plugin. It works, thanks very much for this nice plugin.

Looking forward to trying this, but having problems getting it to run.

Downloaded 32bit msi (to run on XP)
Installed to default loc
Ran via desktop shortcut
Error:

LotroLCD.exe - Entry Point Not Found

The procedure entry point K32GetMappedFileNameW could not be located in the dynamic link library KERNEL32.dll.


Suggestions please?

Thanks in advance.

I've now had a chance to test it and from what I can tell it's still broken, until further notice users of XP should not upgrade to version 1.0.8 or 1.0.9, I'll try to have a patched version out today.

Jarl

I have never seen this issue before, but I'm pretty sure I've found the problem, I just moved my development environment to Visual Studio 2010 and it seems Microsoft broke compatibility with pre windows 7.

See: http://blogs.msdn.com/b/vcblog/archi...orkaround.aspx

I've changed the code to include this fix and made new builds, version 1.0.9 is now out with this included. Same links as before.

I would very much like to know if this solves the issue.

R.

Jarl

Originally Posted by slack_n_hash

Looking forward to trying this, but having problems getting it to run.

Downloaded 32bit msi (to run on XP)
Installed to default loc
Ran via desktop shortcut
Error:

LotroLCD.exe - Entry Point Not Found

The procedure entry point K32GetMappedFileNameW could not be located in the dynamic link library KERNEL32.dll.


Suggestions please?

Thanks in advance.

Thanks for posting, this actually got me on track to fixing a bug that's now apparent, auto-generated initial log files need to have at least one line of text in them otherwise errors will be shown.

R.

Jarl

Originally Posted by Finrandiras

Hello,

I have just tried to run your plugin. It seems to load well:

I start the .exe file
Start lotro
Load char
Load lcd plugin
Start combat logging
<now I can see the ingame pluging window>
When I attack something, it alt+tabs to windows and I get this error:

PointToStart failed with error code6 as follows:
The handle is invalid.

EDIT: And now I see where I did mistake, should start combat logging before loading plugin. It works, thanks very much for this nice plugin.

Just a quick note (win 7 user) and the update worked well for me. Thanks for all the work

Originally Posted by Vindalfur

The error you are referring to is fixed for the next version, actually those errors are not supposed to be shown unless you are developing the application but unfortunately the last version shows it to everyone.

I assume you built it in debug mode instead of release then? Or was this just debug commands within the code that were not removed/commented-out? For this reason it will be nice to have your project/solution file for Visual Studio 2008.

Originally Posted by Vindalfur

Just released version 1.0.8

Mostly version 1.0.8 just fixes bugs and issues found in previous releases, including popup error messages, missing Turbine plugin files when first plugin installed, issues with combat status in LUA plugin, performance and more.

Awesome! I'll give that a try. Thanks.

Originally Posted by cipher_nemo

I assume you built it in debug mode instead of release then? Or was this just debug commands within the code that were not removed/commented-out? For this reason it will be nice to have your project/solution file for Visual Studio 2008.

Awesome! I'll give that a try. Thanks.

Yup, the build must have been in debug mode, I didn't notice until to late.

All the code including project files for VS2008 and VS2010 can be checked out from the SVN repo:

https://lotrolcd.googlecode.com/svn/trunk/

Regards

Jarl

I got my Logitech keypad yesterday. I downloaded this today from your link in the first post.

It installed, I read the readme. I ran LOTRO and upon step 0 I got this same error:

Originally Posted by slack_n_hash

The procedure entry point K32GetMappedFileNameW could not be located in the dynamic link library KERNEL32.dll.

Even though it was then out of order, I tried enabling logging both combat and IMs and got the error again. I ran the plug-in and then tried, got the error.

This is on 32-bit WindowsXP with the LotroLCDInstallerX86.msi installer file.



"Sometimes survival comes down to not being hit. Actually, most times." -the chicken skill, Bob and Weave

Originally Posted by RJFerret

I got my Logitech keypad yesterday. I downloaded this today from your link in the first post.

It installed, I read the readme. I ran LOTRO and upon step 0 I got this same error:

Did you install the Logitech Game Panel software already?

Windows XP (choose 32-bit or 64-bit next)...
G13: http://www.logitech.com/en-us/441/51...ds&bit=&osid=1
G510: http://www.logitech.com/en-us/434/72...ds&bit=&osid=1
G15: http://www.logitech.com/en-us/434/34...ds&bit=&osid=1
G19: http://www.logitech.com/en-us/434/49...ds&bit=&osid=1

Originally Posted by cipher_nemo

Did you install the Logitech Game Panel software already?

Windows XP (choose 32-bit or 64-bit next)...
G13: http://www.logitech.com/en-us/441/51...ds&bit=&osid=1
G510: http://www.logitech.com/en-us/434/72...ds&bit=&osid=1
G15: http://www.logitech.com/en-us/434/34...ds&bit=&osid=1
G19: http://www.logitech.com/en-us/434/49...ds&bit=&osid=1

I do have the g15 software entirely installed previous to any attempt at using the plugin and am also getting the

Originally Posted by slack_n_hash

LotroLCD.exe - Entry Point Not Found

The procedure entry point K32GetMappedFileNameW could not be located in the dynamic link library KERNEL32.dll.

I am running Vista 32 and have also tried it on Win7 32 with the same result.

It's a known issue that crept in during version 1.0.8, it happened because I upgraded my development environment from Visual Studio 2008 to Visual Studio 2010, Microsoft changed the default behavior with one of their libraries which men't it would only work for Vista/Win 7.
I've been busy at work for the last 2 days but I'm spending today on setting up a Win XP testing machine and fixing this.

Originally Posted by Aeonestra

I do have the g15 software entirely installed previous to any attempt at using the plugin and am also getting the

Originally Posted by slack_n_hash

LotroLCD.exe - Entry Point Not Found

The procedure entry point K32GetMappedFileNameW could not be located in the dynamic link library KERNEL32.dll.

I am running Vista 32 and have also tried it on Win7 32 with the same result.

Version 1.1.0 now out

All runtime issues should be fixed for XP users and 64 bit users and issues fixed regarding file paths.

I've tested on clean XP 32 and Win7 32/64 without issues.

Same download links as before.

Originally Posted by Vindalfur

All runtime issues should not be fixed for XP users and 64 bit users and issues fixed regarding file paths.

I assume you mean "now be fixed" instead??

Originally Posted by cipher_nemo

I assume you mean "now be fixed" instead??

lol, yeah :P

I just want to report a bug, that is for 1.0.8.

When everything is running smoothly, but piece of your gears gets damaged, the plugin crashes with error msg something like:

The handled message is too short.

It happened when my cloak Saelchol got damaged.

Thanks for reporting the issue, I have not broken anything in a while but I'll test it asap

Originally Posted by Finrandiras

I just want to report a bug, that is for 1.0.8.

When everything is running smoothly, but piece of your gears gets damaged, the plugin crashes with error msg something like:

The handled message is too short.

It happened when my cloak Saelchol got damaged.

Unfortunately I'm unable to reproduce this, I made an alt, took it to lvl 10 and wrecked a bunch of gear including cloaks but so far nothing, is it possible you still have the log file in question and would be willing to mail it to me?

My email is jarl@dallur.com

Originally Posted by Finrandiras

I just want to report a bug, that is for 1.0.8.

When everything is running smoothly, but piece of your gears gets damaged, the plugin crashes with error msg something like:

The handled message is too short.

It happened when my cloak Saelchol got damaged.

Originally Posted by Vindalfur

Unfortunately I'm unable to reproduce this, I made an alt, took it to lvl 10 and wrecked a bunch of gear including cloaks but so far nothing, is it possible you still have the log file in question and would be willing to mail it to me?

My email is jarl@dallur.com

Sure, I will try to find it.

I'm able to reproduce the issue using the log file you sent me, I get errors for the following items:

Your Saelchol is damaged.
Your Curugor is damaged.
Your Túlloch is damaged.

The reason I did not catch these before is that by default item damaged/broken messages don't go to the combat log and since they contain the string "damage" they got processed when they should have been ignored.

Until a new version is released there is an easy fix for you, filter these messages out of your combat log (see channel filters) but I've fixed it so these messages don't cause errors in future releases even if they are included in the combat log.

Thanks again for reporting this and helping me solve it.

Originally Posted by Finrandiras

I just want to report a bug, that is for 1.0.8.

When everything is running smoothly, but piece of your gears gets damaged, the plugin crashes with error msg something like:

The handled message is too short.

It happened when my cloak Saelchol got damaged.

Is there anyway to log only my skirmish soldier, i wanna compare the dps on runs between two different soldiers and different setups.

In the next version (1.1.1) you can select what you want to show, you could select to only show your skirmish soldier, however if you want to analyze the logs after each skirmish you might want to look into using CStats, it's a stats analyzer for Lotro more focused on allowing you to study the logs in detail after the combat is over.

Jarl

Originally Posted by memanme

Is there anyway to log only my skirmish soldier, i wanna compare the dps on runs between two different soldiers and different setups.

I do use the logs to compare different skills on the soldier but comparing 2 soldiers would take too long.
The next update will be good Thnx

Just uploaded version 1.1.2 which includes a bugfix for a memory leak in version 1.1.1, and a few new things and some bugfixes.


MAKE SURE YOU UNINSTALL ANY PREVIOUSLY INSTALLED VERSIONS of LOTROLCD BEFORE INSTALLING THIS ONE!

Due to the way Windows Installer projects work the installer does not detect previous versions and uninstall because MFC was added to the project.


First of all there is a whole new windows UI, it does not do much at the moment but at least you can start/stop without using the task manager, unfortunately this increases the size of the downloads and memory usage somewhat.

Secondly there is now a configure/settings button which allows users do change which data elements are shown and the opacity of the stats window.

Thirdly I have fixed some bugs and improved the detection methods used for log and communications files so that it should not longer matter at all if LotroLCD is started before the Lotro client or not.

Last but not least the plugin should now be compatible with the Nov 29 update.

Unfortunately I was not able to complete the message/timer system for the LUA plugin in time for this release but It's close and just requires a bit of LUA UI work, hopefully I'll release it sometime next week after the Nov 29 upgrade.

Update: FYI there was a small memory leak in version 1.1.1, it should be corrected in version 1.1.2

Please let me know of any issues or problems you encounter.

Thank you so much for doing this, keep up the great work.

I have just noticed what you have posted in other thread about the debuff timer, that would be brilliant. My main class is hunter, so the DOT I use most is barbed arrow, which makes quite a chunk of my dps. So being able to clearly see my own timer is very good.

As it is now, it is almost impossible to track my own DOT if there are more hunters using barbed arrow on the same target as me. Doesn't look like lotro devs are going to put any effort into solving that, so plugins like yours are really usefull.

Okay, so i've downloaded the correct one (win7 32bit), Installed it, and tried about 500 different orders to get it to start in the game. All i get is the LotroLCD window without any values after the words, just dashes. I've got my combat logged, and my IM to myself, but still no progress on the dashes.



Nevermind, apparently it decided it wanted to work today. It's a great plugin thanks!

Thanks,

For the skill tracking, after working with LUA for a while I think I have a way of doing a timer/skill tracker implemented in pure LUA which would be much more user friendly than the current system, perhaps one day I'll find the time to implement it

Jarl

Originally Posted by Finrandiras

Thank you so much for doing this, keep up the great work.

I have just noticed what you have posted in other thread about the debuff timer, that would be brilliant. My main class is hunter, so the DOT I use most is barbed arrow, which makes quite a chunk of my dps. So being able to clearly see my own timer is very good.

As it is now, it is almost impossible to track my own DOT if there are more hunters using barbed arrow on the same target as me. Doesn't look like lotro devs are going to put any effort into solving that, so plugins like yours are really usefull.

Okay, sorry for posting 2 replies, but I've got another issue. When i log on my warden, all I've gotta do is start logging the combat log. But whenever i log on my Hunter, and log the combat log, it doesn't show anything but dashes again. What do i have to do when i switch characters for it to log?

I find this to be strange, the data exchange should happen with the same file so you should be able to have any character logged on, I'll look into it when I have the time.

Jarl

Originally Posted by Morte

Okay, sorry for posting 2 replies, but I've got another issue. When i log on my warden, all I've gotta do is start logging the combat log. But whenever i log on my Hunter, and log the combat log, it doesn't show anything but dashes again. What do i have to do when i switch characters for it to log?