Thread: [Plugin] LotroLCD

Lotro LCD is a combat and chat log analyzer with Lotro plugin to show stats in game or on a Logitech G series keyboard LCD, it will show stats such as dps, total dmg per combat, total heals per combat, etc.

A Logitech keyboard is not required, to run the plugin!

Here is a screenshot showing the plugin with the ingame LUA interface (no logitech keyboard required!):




Here are some screenshots showing the plugin running on a logitech keyboard:




Lotro LCD consists of two parts, a log parser written in C++ that looks for new log files, parses them, analyses and then makes the information available for the Lotro LUA plugin which is the second part.

To use Lotro LCD, download the installer and install LotroLCD, run LotroLCD by doubleclicking the desktop icon or the link in your start menu, launch Lotro, once inside Lotro turn on logging for your Combat channel and load the plugin with /plugins load LotroLCD

Combat analysis and IM log analysis/timer functionality is now available for both Logitech Keyboard LCDs and the in-game plugin.

LotroLCD will only work with the english version of the Lotro client.

The primary location for the LotroLCD installers (where updated versions show up first) is at the following location:

http://dallur.com/fileadmin/user_upl...rX86-1.1.4.msi (32bit)
http://dallur.com/fileadmin/user_upl...rX64-1.1.4.msi (64bit)


All the code is licensed under GPL v2 and is hosted at googlecode:
https://lotrolcd.googlecode.com/svn/trunk/

Submissions, suggestions, patches and contributions of all sorts are encouraged and welcomed, mail or message me the patches or tell me if you want commit access to the subversion repository.

Very interesting... will give this a go tonight with my G15.

For those of you who may be concerned about downloading and using third party .exe, this looks totally legit so far... will update if it steals my firstborn and uploads it to 4chan.

So we have to load this program BEFORE we load LOTRO? and hence BEFORE we enter our LOTRO password and login details?

Does the program still work if we have already logged into LOTRO?

Sure, you can launch it after you log into the game, should not matter.

If you want to make sure the code isn't doing anything it should not be doing I can send it to you for review or so you can compile yourself.

Jarl

I am getting an error message when starting the LOTRO LCD program (from the shortcut). It reads:

Error Finding Logitech Keyboard and Lotro Log Files : Failed with error code 6 as follows: The handle is invalid.

Please advise.

I have verified, the reason is that the application won't start until it finds at least one chat log and one combat log, my bad I just never tested that, it should handle that scenario more gracefully, I probably need to create some sort of GUI warning that pops up and tells users to click "this button" when they have started lotro and created some log files.

I'll post here when a new fixed version is ready and uploaded.

Jarl

OK, I don't know exactly why your getting that error but It probably has something to do with the app not finding any log files in your lotro directory, I'm trying to reproduce it as we speak, you can try logging in and creating some files in the meantime, i'll post as soon as I have reproduced.

That's an easy enough issue to resolve on my end. I recently moved all my chat logs out of my LOTRO folder. Thanks for the help.

Thanks for reporting the issue, it's hard to be a one man dev team, sometimes you forget to test things like delete all log files from your lotro folder when running the client

I've patched the program and made version 1.0.3 which has a temporary fix, the fix means that if no log file is found it creates 2 dummy files, I want to handle this more gracefully in the future but it will do for now.

Regards

Jarl

I spoke too soon. I resolved the "missing logs" issue, but I am still getting the same error. As I understand it, the "My Documents" file route for Windows 7 is just that bit different and I am still using XP, is it possible that could be an issue?

Originally Posted by SaintBass

I spoke too soon. I resolved the "missing logs" issue, but I am still getting the same error. As I understand it, the "My Documents" file route for Windows 7 is just that bit different and I am still using XP, is it possible that could be an issue?

Can you try the newer version I made (same download link) and see if you still have the issue with it?

Thanks for being so patient, it's really helpful to get some feedback to resolve bugs I missed during my testing..

I'll get back around to it in around 10 hours, but I'll definitely lend a hand tonight (my time) with the new version.

OK, so I did the following, but it is still not quite functioning:

1. Start client
2. Start LOTRO LCD script from desktop shortcut (no error this time)
3. Load character
4. Start combat chat log
5. load Lua Script

The Lua script only presents a black window with the text "LotroLcd" within. I can cycle through my G15 LCD display and I get a message there that states, "Combat or IM log missing. Start logging both in the Lotro client. See ReadMe.txt for more information."

So, it seems that everything is otherwise working well, except for the auto-detect combat log feature.

Hope that helps. I may not be around much tonight, but I am willing to continue to be the guinea pig on this one. Would very much like to have an LCD display of my DPS in real time.

Originally Posted by SaintBass

OK, so I did the following, but it is still not quite functioning:

1. Start client
2. Start LOTRO LCD script from desktop shortcut (no error this time)
3. Load character
4. Start combat chat log
5. load Lua Script

The Lua script only presents a black window with the text "LotroLcd" within. I can cycle through my G15 LCD display and I get a message there that states, "Combat or IM log missing. Start logging both in the Lotro client. See ReadMe.txt for more information."

So, it seems that everything is otherwise working well, except for the auto-detect combat log feature.

Hope that helps. I may not be around much tonight, but I am willing to continue to be the guinea pig on this one. Would very much like to have an LCD display of my DPS in real time.

Just to verify, this is with a client downloaded and installed from:
http://dallur.com/fileadmin/user_upl...stallerX86.msi after 09:00 GMT 12th of October right?

I added a patch yesterday morning that fixes an annoying bug, the bug required at least one combat log and one IM log to be present in the lotro log directory, if one of each wasn't present it would show that error and never start parsing log files. The most current version should not be affected by the bug, it circumvents the bug by creating two dummy log files Combat_2000010_1.txt and IM_20000101_1.txt, I'm going to fix it more permanently later but for now can you verify that those two files have been created or that there is at least 1 combat log and 1 IM log in your log directory?

R.
Jarl

Originally Posted by Vindalfur

All the code is licensed under GPL v2 so feel feel to contact me if you want to get the code since I don't have a public code repository yet.

I would like a copy of your source code, please. Just shoot me a PM with it. I can also host files for you if you like.

Originally Posted by Vindalfur

Just to verify, this is with a client downloaded and installed from:
http://dallur.com/fileadmin/user_upl...stallerX86.msi after 09:00 GMT 12th of October right?

I added a patch yesterday morning that fixes an annoying bug, the bug required at least one combat log and one IM log to be present in the lotro log directory, if one of each wasn't present it would show that error and never start parsing log files. The most current version should not be affected by the bug, it circumvents the bug by creating two dummy log files Combat_2000010_1.txt and IM_20000101_1.txt, I'm going to fix it more permanently later but for now can you verify that those two files have been created or that there is at least 1 combat log and 1 IM log in your log directory?

R.
Jarl

That is correct, that is the version I am using as of last attempt. Those dummy files are not being created on my system and I have since created a few other combat, IM and general chat logs for good measure.

For reference, in case this is simply an issue between the Documents Folders for XP and Windows 7, this is where my logs and plugin folders are located on my system.

C:\Documents and Settings\*UserName*\My Documents\The Lord of the Rings Online

As I understand it, Vista and 7 have done away with the big Documents and Settings folder so the file route to the LOTRO folder will be just that bit different. That could be where your detection script is hitting a wall.

I'll install an XP virtual machine tonight and test, I'll let you know in a couple of hours..

Jarl

Originally Posted by SaintBass

That is correct, that is the version I am using as of last attempt. Those dummy files are not being created on my system and I have since created a few other combat, IM and general chat logs for good measure.

For reference, in case this is simply an issue between the Documents Folders for XP and Windows 7, this is where my logs and plugin folders are located on my system.

C:\Documents and Settings\*UserName*\My Documents\The Lord of the Rings Online

As I understand it, Vista and 7 have done away with the big Documents and Settings folder so the file route to the LOTRO folder will be just that bit different. That could be where your detection script is hitting a wall.

Originally Posted by cipher_nemo

I would like a copy of your source code, please. Just shoot me a PM with it. I can also host files for you if you like.

I wan't to try as much as possible to keep the code from branching (unless branching is required), I'll set up a public git repository and upload the code tonight, once it's up I'll message you with the details so you can test.

Unfortunately I was forced to do the project with MS Visual Studio to use the Logitech libraries so it will require MS Visual Studio 2008 or newer.

I also want to mention that some of the code is quite ugly, I'm using the project to teach myself C/C++ and I know enough to know it's ugly.

I have been using this program/plug in for 3 days now with no problems. I love it and the fact it work for all

classes is great.

Thanks so much for the time and effort you have put into such a nice addition to the game.

Originally Posted by Vindalfur

I wan't to try as much as possible to keep the code from branching (unless branching is required), I'll set up a public git repository and upload the code tonight, once it's up I'll message you with the details so you can test.

Unfortunately I was forced to do the project with MS Visual Studio to use the Logitech libraries so it will require MS Visual Studio 2008 or newer.

I also want to mention that some of the code is quite ugly, I'm using the project to teach myself C/C++ and I know enough to know it's ugly.

No problem. I use Visual Studio 2008 as well. So the entire solution w/ project(s) would be great. And not really concerned with beauty of the code, just as a learning example when I make add-ons for LOTRO's UI as well.

Originally Posted by cipher_nemo

No problem. I use Visual Studio 2008 as well. So the entire solution w/ project(s) would be great. And not really concerned with beauty of the code, just as a learning example when I make add-ons for LOTRO's UI as well.

I tried adding it as a git project at Sourceforge but someone there needs to pull his head out of ..... nothing works.

So instead of a native git repository I created a SVN repo at googlecode, from now on I'll push any changes to this location and this will be the authoritative source location.

https://lotrolcd.googlecode.com/svn/trunk/

Let me know if you have patches or need commit access.

Originally Posted by Vindalfur

So instead of a native git repository I created a SVN repo at googlecode, from now on I'll push any changes to this location and this will be the authoritative source location.

https://lotrolcd.googlecode.com/svn/trunk/

Let me know if you have patches or need commit access.

Thanks! Could you zip up the solution as you have it in VS2008 so that all of the project properties and references/dependencies are there? I only see the code files, dlls/libraries, etc. at that link. No project or solution files.

Originally Posted by cipher_nemo

Thanks! Could you zip up the solution as you have it in VS2008 so that all of the project properties and references/dependencies are there? I only see the code files, dlls/libraries, etc. at that link. No project or solution files.

It should be complete with the project, see https://lotrolcd.googlecode.com/svn/...rser/LotroLCD/

Originally Posted by SaintBass

That is correct, that is the version I am using as of last attempt. Those dummy files are not being created on my system and I have since created a few other combat, IM and general chat logs for good measure.

For reference, in case this is simply an issue between the Documents Folders for XP and Windows 7, this is where my logs and plugin folders are located on my system.

C:\Documents and Settings\*UserName*\My Documents\The Lord of the Rings Online

As I understand it, Vista and 7 have done away with the big Documents and Settings folder so the file route to the LOTRO folder will be just that bit different. That could be where your detection script is hitting a wall.

I think I've found the issue and fixed it (you were right, I assumed the directory was named Documents, not My Documents), I made a special build with the path, can you test and verify that this fixes the issue?

I will absolutely download and test that... should have some information for you in a couple of hours, possibly sooner.

That did the trick. Everything seems to be running smoothly and producing accurate data.

Nicely done.

Originally Posted by SaintBass

That did the trick. Everything seems to be running smoothly and producing accurate data.

Nicely done.

Great!

Thanks for helping me solve that, I'm sure that's been affecting lots of users, let me know if there is anything else, features or bugs.

Originally Posted by Vindalfur

Great!

Thanks for helping me solve that, I'm sure that's been affecting lots of users, let me know if there is anything else, features or bugs.

Not a problem. I'll put it through its paces and take note of anything that crops up, but so far, its the exact functionality that was looking for in a DPS readout. Everything else that has been released until this has shown the information after the fact while I have always wanted to see it in real time.

Thank you for the outstanding work.

Originally Posted by Vindalfur

It should be complete with the project, see https://lotrolcd.googlecode.com/svn/...rser/LotroLCD/

Awesome, thanks! I didn't see that at first.

Using it for a day, seems to work fine except for having to start IM and chat logging prior to loading the plugin. I have Vista 32bit and I am running the 32 bit version of LCD.

Feature request:

Can you add the fight time ala DPS Meters?

Originally Posted by Willaren

Using it for a day, seems to work fine except for having to start IM and chat logging prior to loading the plugin. I have Vista 32bit and I am running the 32 bit version of LCD.

Feature request:

Can you add the fight time ala DPS Meters?

Sure, I've added an issue to my issue tracker (http://code.google.com/p/lotrolcd/issues/list), I'll try to have it done by the end of the day (I have to got to work first).

Just a suggestion. Can Someone edit the Frist Post with Pictures of this Plug in action. Really it sounds like a neat feature. But I dont have that that verson of Logitech keyboard.

Originally Posted by Celt_Ainvar

Just a suggestion. Can Someone edit the Frist Post with Pictures of this Plug in action. Really it sounds like a neat feature. But I dont have that that verson of Logitech keyboard.

Thanks for the tip, better now?

I just released version 1.0.5 (same download links)

Version 1.0.5 adds a combat timer showing the total time since the combat started and sorted damage (Common, Fire, etc) types are now available to LUA although they are not shown because they would clutter current UI.
Also the client now prevents more than one instance to run on the same machine to prevent multiple running clients.

One glitch that I have noticed is that it does not always stop parsing when combat ends... I once had an entire skirmish logged as a single encounter.

Originally Posted by SaintBass

One glitch that I have noticed is that it does not always stop parsing when combat ends... I once had an entire skirmish logged as a single encounter.

Yes this can happen, what I do when parsing the logs is that I build a list of all the enemies which you, your pet or your skirmish pet has hit or been hit by, when a defeat message is shown I remove the corresponding entry from this list.

Unfortunately due to various issues the logs don't always show defeat messages for all enemies so there is a failsafe mechanism that kicks in if nobody has been damaged for 30 seconds, I tried having this set to a lower value but then it would kick in during large raid combats.

A good example of this issue would be "elements" in skirmishes, often you get damaged by objects which can't/don't ever get defeated but currently the log parser can't tell the difference, One of my "things to do" is to make a complete list of all these "elements" and exclude them from the enemy list.

The only way I know of to fix this 100% is to have the LUA plugin send a message to the C code telling it when your character enters and exits combat, this is on my list of things to do, see http://code.google.com/p/lotrolcd/issues/detail?id=5

You should also check and make sure you have version 1.0.5 installed, I fixed a bug in 1.0.4 which substantially reduced the frequency of this happening.

I don't know when this will get fixed but as a workaround if you wait for 30 seconds it should clear up or alternatively if you have a Logitech G series keyboard you can reset the app/stats by hitting the left-most button of the four elongated buttons under the screen.

Originally Posted by Vindalfur

Yes this can happen, what I do when parsing the logs is that I build a list of all the enemies which you, your pet or your skirmish pet has hit or been hit by, when a defeat message is shown I remove the corresponding entry from this list.

Unfortunately due to various issues the logs don't always show defeat messages for all enemies so there is a failsafe mechanism that kicks in if nobody has been damaged for 30 seconds, I tried having this set to a lower value but then it would kick in during large raid combats.

The only way I know of to fix this is to have the LUA plugin send a message to the C code telling it when your character enters and exits combat, this is on my list of things to do, see http://code.google.com/p/lotrolcd/issues/detail?id=5

I don't know when this will get fixed but as a workaround if you wait for 30 seconds it should clear up or alternatively if you have a Logitech G series keyboard you can reset the app/stats by hitting the left-most button of the four elongated buttons under the screen.

OK good to know... I will make a point of manually resetting since I am primarily using the G15 display.

Would it be possible to set up a toggle-able feature where we can choose whether the dps average does or does not reset outside of combat. I'd like to run it through several mobs to get a good idea of my dps, but it resets out of combat and my numbers no longer become a true average. The more hits I do the more accurate the dps reading will be.

Just a thought!

Awesome job on the plugin so far btw!

Originally Posted by Shewtemup

Would it be possible to set up a toggle-able feature where we can choose whether the dps average does or does not reset outside of combat. I'd like to run it through several mobs to get a good idea of my dps, but it resets out of combat and my numbers no longer become a true average. The more hits I do the more accurate the dps reading will be.

Just a thought!

Awesome job on the plugin so far btw!

Everything is possible, and this should be pretty easy. I'm assuming you don't want the timers to keep running outside combat so that you DPS keeps counting down between mobs but rather that you want an average DPS for several fights.

I'm thinking the easiest way is to do it in LUA since there is no new data involved, only a question of presenting it in the right way. I'll add it to my "issues" list and aim to have it done for the next release.

http://code.google.com/p/lotrolcd/is...&ts=1287829715

Thanks for your kind words, I wish I had more time to improve this plugin (especially the LUA UI), who knows, maybe someone else will join in at some point.

I didn't have time to read through all the thread to find this answer if it's there, but is there a way to keep the timer from resetting? I'd like to just see my average dps after a few minutes of playing as opposed to every mob. Actually... a toggle-able option for that would be sweet.

Originally Posted by Shewtemup

I didn't have time to read through all the thread to find this answer if it's there, but is there a way to keep the timer from resetting? I'd like to just see my average dps after a few minutes of playing as opposed to every mob. Actually... a toggle-able option for that would be sweet.

I have a feature request from another user for just this, showing average dps per session with an optional reset button, It's going to be included in the next release which should be ready soon.